Dependency path wrapping + cleanup#2325
Conversation
|
There is a question about include-paths of dependencies. Do we strictly want all dependencies to be placed in a subdirectory (unless, of course, this is already done upstream)? This seems to be a bit inconsistent. Tests are good. |
|
The paths for |
|
|
mazunki
force-pushed
the
fix-include-deps
branch
from
066f6fa to
1e78d35
Compare
|
Rebased to fix merge conflicts, but there's still the question of whether we want to strictly enforce including headers coming from dependency as |
MagnusS
left a comment
MagnusS
left a comment
There was a problem hiding this comment.
I started reviewing this, but the changes are mixed with indentation updates (mainly due to added "let") and renamed files, making it hard to see your actual changes. Please move cleanup/formatting to a separate PR that only focusses on this
|
|
||
| # most clangd configurations and editors will look in ./build/, but this just makes it easier to find for some niche edge cases | ||
| ln -sfn "${buildpath}/compile_commands.json" "$IOS_SRC/compile_commands.json" | ||
| # ln -sfn "${buildpath}/compile_commands.json" "$IOS_SRC/compile_commands.json" |
There was a problem hiding this comment.
If no longer needed, just remove the line?
There was a problem hiding this comment.
There are some issues caused by reusing the same build/ directory between IncludeOS, tests and the example unikernel. I left the line around until this is properly fixed so it's easy to uncomment for now.
mazunki
force-pushed
the
fix-include-deps
branch
from
1e78d35 to
ad8dcc5
Compare
2 participants
In order to more easily get clangd happy, I've set up
${dependency}.includeand${dependency}.libtargets to alldeps/(except lest, which is header-only. We should consider precompiling it), instead of requiring to guess these paths every time they're used.I've also nixified
deps/libfdt. Prior to this, we were hoping it was installed on the system, and somehow that was ok. Now we're properly depending on it.Lastly, I've patched
s2n-tlsso that it actually compiles. It's still not linking due to-lgcc_eh, due to static builds... but better something than nothing.